perf(runner): single uname fork at cold start#799
Merged
Conversation
check_os.sh forked `uname` twice per load: once at module scope and again inside check_os::init (invoked at load). init sets _BASHUNIT_UNAME before any reader runs, so the module-scope call was dead weight — one redundant fork on every one of the acceptance suite's 258 nested bashunit cold starts. Closes #798
JesusValeraDev
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #798
Profiling the acceptance suite's nested
bashunitcold starts (the frontier from #761) showedcheck_os.shforkingunametwice on every load.💡 Changes
unamecall;check_os::init(run at load) already sets_BASHUNIT_UNAMEbefore any reader, cutting one fork per cold start.unamecall.