perf(runner): drop round-2 fork leftovers from #761#797
Merged
Conversation
wait_for_job_slot now counts running jobs via a fork-free line count over jobs -pr (return slot) instead of jobs -r | wc -l on every poll (145 -> 0 wc forks across a small parallel run). check_duplicate_functions folds its per-file grep + awk + sort + uniq into a single awk pass + sort. No behaviour change; output and return codes are identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #761
Two small per-run fork leftovers remained from the round-2 perf work:
wait_for_job_slotshelled out towcon every poll, andcheck_duplicate_functionsran a grep + awk + sort + uniq chain per test file.💡 Changes
wait_for_job_slotcounts running background jobs with a fork-free pure-bash line count overjobs -pr(via a return slot) instead ofjobs -r | wc -l— 145 → 0wcforks across a small parallel runcheck_duplicate_functionsfolds its per-file grep + awk + sort + uniq scan into a single awk pass + sort; output and return codes are byte-identical