Skip to content

test(assert): drop jq from flaky custom-assertion test #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chemaclass merged 1 commit into from
Jul 14, 2026
Merged

test(assert): drop jq from flaky custom-assertion test #794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions tests/unit/custom_assertions_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
#!/usr/bin/env bash

# Custom assertion that uses fail internally
# Custom assertion that uses fail internally.
# jq-free on purpose: this scaffolding only needs to route a failure through
# bashunit::fail deterministically; depending on the external jq binary made the
# test flaky on the macOS CI runner while the pure-bash sibling tests never were.
function _assert_valid_json() {
local json="$1"

if ! echo "$json" | jq . >/dev/null 2>&1; then
case "$json" in
'{'*'}' | '['*']') bashunit::state::add_assertions_passed ;;
*)
bashunit::fail "Invalid json: $json"
return
fi

bashunit::state::add_assertions_passed
;;
esac
}

# Custom assertion that uses bashunit::assertion_failed
Expand Down
Loading