fix: update selected inline content styling - #2983
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe editor adds a dedicated selection overlay for inline nodes. The overlay uses a darker translucent background and removes the inset border. Other selected nodes keep the existing styling. ChangesInline selection styling
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change only updates the visual styling of selected inline content while leaving selected block styling unchanged; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/diagram-block
@blocknote/mantine
@blocknote/math-block
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
|
|
Nice. Tested on both dark and light mode? seems like those should be different colors, right? |
|
I wonder if it would've been better as an outline rather than a border? |
Color is the same for both because it's a translucent overlay, so it looks different on light and dark mode because the light/dark background is still visible behind it.
Tried that but wasn't a fan. For selected inline content to look good with a border you'd need to add padding, else the border can overlap content inside. The added padding then looks weird when the inline content isn't selected, as there is additional empty space before and after. I briefly considered adding the padding only when selected but having text around the inline content get repositioned because of it felt janky. |
Summary
This PR removes the border from selected inline content and changes the background to a more visible color. Selected block styling remains the same.
Rationale
The current selected inline content styling looks off.
Changes
Impact
N/A
Testing
N/A
Screenshots/Video
Before:
After:
Checklist
Additional Notes
Summary by CodeRabbit