Repository navigation
Conversation
A build with only the cli feature failed. The lsp and watch arms in main.rs called tokio and the lsp and watch modules with no cfg check. Those exist only with the lsp and watch features. Both arms now follow the mcp arm: built without the feature, the subcommand says so and exits 1. Four helpers that only the pandoc and neural paths call get a cfg_attr allow, so the cli-only build has no dead-code warnings. The WASM workflow now checks the cli-only binaries with warnings denied, and a change to that workflow triggers it on pull requests too.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo build --no-default-features --features clifailed on main.The
lspandwatcharms insrc/main.rsusedtokio,snapper_fmt::lspandsnapper_fmt::watchwith no cfg gate, and those exist only with thelspandwatchfeatures.mcparm.Built without the feature,
snapper lsporsnapper watchprints which feature is missing and exits 1.is_rst_dropped_comment_opener,source_has_dropped_rst_comments,wrap_sentence_plainandverbatim_commandsserve only the pandoc or neural paths.A
cfg_attrallow keeps the cli-only build free of dead-code warnings.test-featuresjob inwasm.ymlrunscargo check --no-default-features --features cli --binswithRUSTFLAGS=-D warnings.The workflow file now also triggers that job on pull requests.
The cli-only check fails on main and passes here.
cargo test,cargo test --no-default-features --lib,cargo clippy -- -D warningsandcargo fmt --checkpass.