Repository navigation
fix: two missed Markdown splits and table rows - #528
Merged
Merged
Conversation
A `` with no '' after it held a LaTeX quote open to the end of the paragraph. Every later sentence stayed on its line. CommonMark reads an unmatched backtick run as literal text. The delimiter walk now counts the '' closers ahead and opens a quote only when one is left to close it. A closed ``quote'' still keeps its sentences together.
A GFM table runs to a blank line or to a block that interrupts a paragraph (GFM ex. 202). A line under the last row with no pipe is one more row. The parser read it as prose and split it, which added a row. The CLI render check then reverted that line with a warning. The table now takes such lines, as pulldown-cmark does. A list item, heading, fence, quote, HTML block or footnote ends it. A line indented less than the header ends it too, since it may belong to an outer container. The light-table test expected the split, so it now checks the row and a later paragraph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups to #524 and #526, each with a regression test.
with no `''` after it held a LaTeX quote open, so the rest of the paragraph stayed on one line. The delimiter walk now opens a quote only when a closer is left, as CommonMark reads an unmatched backtick run as literal. `Unclosedtick here. Next sentence.` now splits.snapper split it as prose and the CLI render check reverted it with a warning.
The table now runs to a blank line or a block that interrupts a paragraph.
A list item, heading, fence, quote, HTML block, footnote or a line indented less than the header still ends it.
heavy_table_still_interruptsexpected that line to split, so it now checks the row and a later paragraph.The new tests fail on main and pass here.
cargo test,cargo clippy -- -D warningsandcargo fmt --checkpass.