Lily/MoreEvents: added "whenProjectPaused" and "whenProjectUnPause"#2040
Lily/MoreEvents: added "whenProjectPaused" and "whenProjectUnPause"#2040The11thPencil wants to merge 5 commits intoTurboWarp:masterfrom
Conversation
github-actions
Bot
added
the
pr: change existing extension
|
!format |
| const topBlockId = script.blockId; | ||
| for (let j = 0; j < runtime.threads.length; j++) { | ||
| if ( | ||
| runtime.threads[j].topBlock === topBlockId && |
There was a problem hiding this comment.
This does not account for clones properly. The script is only going to run in one of the clones at a time since theyll have the same top block ID
There was a problem hiding this comment.
i am not quite sure how to fix this..
This comment was marked as abuse.
This comment was marked as abuse.
|
wait why is this closed, i didnt meant to close it lol |
|
I'm not a big fan of doing this as it is interfacing with a feature that is introduced through an addon and nothing internally. I'd rather it be introduced into a separate extension like Runtime Options, not here. |
|
!format |
|
@fath11 this is similar to (though not an exact duplicate of) #1245. According to #2271, we should do our best to avoid similar/duplicate pull requests by encouraging collaboration instead of "one is better than the other". Since @LilyMakesThings would prefer this kind of functionality in a separate extension and #1245 already has this functionality, @fath11 are you okay if I close this? You could always collaborate with @SharkPool-SP to get this extra pause functionality to Turbowarp |
|
Yes I am okay if this is closed |
|
Okay, hope this won't upset you |
6 participants
No description provided.