Skip to content

🛡️ Sentinel: [CRITICAL] Fix hardcoded JWT secret fallback in templates #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tuntii wants to merge 1 commit into from
Closed

🛡️ Sentinel: [CRITICAL] Fix hardcoded JWT secret fallback in templates #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/cargo-rustapi/src/templates/full.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ pub async fn login(Json(body): Json<LoginRequest>) -> Result<Json<LoginResponse>
// TODO: Validate credentials against your database
if body.username == "admin" && body.password == "password" {
let jwt_secret = std::env::var("JWT_SECRET")
.unwrap_or_else(|_| "dev-secret-change-in-production".to_string());
.map_err(|_| ApiError::internal("JWT_SECRET environment variable is not set"))?;
Comment on lines 172 to +173

let claims = UserClaims {
sub: "1".to_string(),
Expand Down
Loading