Add regression coverage for missing plugin commit descriptors#6
Draft
cursor[bot] wants to merge 4 commits into
Draft
Add regression coverage for missing plugin commit descriptors#6cursor[bot] wants to merge 4 commits into
cursor[bot] wants to merge 4 commits into
Conversation
Added grand-flip-out plugin with repository details and warning.
Co-authored-by: Tunatroll <Tunatroll@users.noreply.github.com>
Co-authored-by: Tunatroll <Tunatroll@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commitkey.PluginBuildExceptionfor missing commits instead of allowing aNullPointerException.Risky Behavior Now Covered
commit=now fail through the normal validation path with actionable error context.Test Files Added/Updated
package/package/src/test/java/net/runelite/pluginhub/packager/PluginTest.javaWhy This Reduces Regression Risk
Validation
./gradlew --console=plain prep./gradlew --console=plain :package:test --tests net.runelite.pluginhub.packager.PluginTest.testCommitMustBePresentfirst failed red withNullPointerException, then passed after the fix../gradlew --console=plain :package:compileJava :package:compileTestJava :package:test --tests net.runelite.pluginhub.packager.PluginTest.testCommitMustBePresentpassed.Notes
./gradlew --console=plain :package:testwas attempted but existing example-plugin compile tests fail in this environment under Java 21; CI uses Java 11 per.github/workflows/build.yml.