Add regression coverage for packager validation paths#5
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Added grand-flip-out plugin with repository details and warning.
Co-authored-by: Tunatroll <Tunatroll@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PluginTest:disabled=andunavailable=descriptors preserve their different unavailable-manifest semanticsUploadConfigurationTestcoverage for recursive WebDAVMKCOLbehavior when a child directory returns409before its parent exists.Risky Behavior Now Covered
Test Files Added/Updated
package/package/src/test/java/net/runelite/pluginhub/packager/PluginTest.javapackage/upload/src/test/java/net/runelite/pluginhub/uploader/UploadConfigurationTest.javaWhy This Reduces Regression Risk
409parent-directory recovery is disabled.Validation
./gradlew prepsucceeded../gradlew :package:test --tests net.runelite.pluginhub.packager.PluginTest.testRepositoryMustBeGithubCloneUrl --tests net.runelite.pluginhub.packager.PluginTest.testUnexpectedCommitDescriptorKeyFailsFast --tests net.runelite.pluginhub.packager.PluginTest.testDisabledCommitDescriptorIsExcludedFromUnavailable --tests net.runelite.pluginhub.packager.PluginTest.testUnavailableCommitDescriptorIsIncludedInUnavailable :upload:test --tests net.runelite.pluginhub.uploader.UploadConfigurationTestPluginTestclass still hits pre-existing generated example-plugin compile failures unrelated to these new constructor-level tests.