Add warning metadata regression coverage#4
Draft
cursor[bot] wants to merge 4 commits into
Draft
Conversation
Added grand-flip-out plugin with repository details and warning.
Co-authored-by: Tunatroll <Tunatroll@users.noreply.github.com>
Co-authored-by: Tunatroll <Tunatroll@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
warning=metadata.Risky Behavior Now Covered
Recent merged descriptors can include user-facing warning text, such as IP-address disclosure. This test guards against regressions that would drop that warning from display metadata.
Test Files Added/Updated
package/package/src/test/java/net/runelite/pluginhub/packager/PluginTest.javaWhy This Reduces Regression Risk
Warnings communicate material user safety/privacy information. If warning propagation breaks, plugins may still package without surfacing that disclosure to users. The test is deterministic and avoids the existing nested plugin-build path that is environment-dependent.
Validation
./gradlew --console=plain prep./gradlew --console=plain :package:test --tests net.runelite.pluginhub.packager.PluginTest.testWarningIsIncludedInDisplayData --rerun-tasksdisplayData.setWarning(warning)and confirmed the new test failed, then restored it and confirmed it passed.