Add descriptor validation regression tests#2
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Added grand-flip-out plugin with repository details and warning.
Co-authored-by: Tunatroll <Tunatroll@users.noreply.github.com>
Tunatroll
pushed a commit
that referenced
this pull request
May 21, 2026
* Update hallowed-sepulchre-helper * Update hallowed-sepulchre-helper pluginhub compliance #2 pass remove floor 4 phase tracker remove countdown from portals, wizards and knight statues remove knight statue zone highlight (both warning and hazard) remove warning highlight for wizard statues * Update plugins/hallowed-sepulchre-helper --------- Co-authored-by: Rhea <napkinorton@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commit=andrepository=validation.commit=descriptors to fail withPluginBuildExceptioninstead of throwing through the regex matcher.Risky behavior now covered
commit=values in frequently edited plugin descriptors.repository=values.Test files added/updated
package/package/src/test/java/net/runelite/pluginhub/packager/PluginTest.javaWhy this reduces regression risk
Recent merged changes primarily update plugin descriptor files, so constructor-level validation is the shared gate for catching malformed descriptors before packaging. These tests prove bad descriptor metadata produces actionable validation failures instead of crashes or accidental acceptance.
Validation
./gradlew --console=plain prep :package:test --tests net.runelite.pluginhub.packager.PluginTest.testCommitMustBePresent --tests net.runelite.pluginhub.packager.PluginTest.testCommitMustBeComplete --tests net.runelite.pluginhub.packager.PluginTest.testRepositoryMustBePresent --tests net.runelite.pluginhub.packager.PluginTest.testRepositoryMustBeGithubCloneUrl./gradlew --console=plain prep :package:test --tests net.runelite.pluginhub.packager.PluginTesthas unrelated existing integration failures in this environment while compiling generated example plugins.