Apply the 72-hour pnpm baseline to Source - #198
Draft
9larsons wants to merge 2 commits into
Draft
Conversation
ref https://linear.app/ghost/issue/PLA-321/make-the-72-hour-pnpm-cooldown-explicit-across-first-party-themes Source is installed both as Ghost's default-theme submodule and as a standalone release archive, so both paths should retain the same explicit 72-hour cooldown and fail-closed pnpm policy without permitting dependency lifecycle scripts.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
minimumReleaseAge: 4320to enforce an explicit 72-hour dependency cooldown.strictDepBuilds: trueso unapproved lifecycle scripts fail installation.blockExoticSubdeps: trueso transitive dependencies cannot resolve from exotic Git or tarball sources.dtrace-provider: falsedenial.allowBuilds: trueentries.pnpm-workspace.yamlin the generated standalonesource.zipso standalone installs receive the same policy.Why
Source is consumed in two forms: Ghost updates it as a full git submodule, and Source releases a standalone theme archive. The submodule path already carries the root configuration, but the zip task explicitly removed
pnpm-workspace.yaml, leaving the standalone artifact without the repository's dependency-install policy.Both paths now retain the same explicit 72-hour and fail-closed pnpm controls without permitting any dependency lifecycle scripts.
This is the Source portion of PLA-321.
Impact
There is no theme runtime behavior change. Newly published dependencies wait 72 hours, unapproved build scripts fail installation, and exotic transitive sources are blocked. The standalone theme zip gains the small pnpm policy manifest; it continues to exclude
pnpm-lock.yamland other development-only files.Validation
corepack pnpm --version(11.19.0)pnpm config getcorepack pnpm install --frozen-lockfile(751 lockfile entries passed supply-chain policy verification)corepack pnpm buildcorepack pnpm test:ci(zip generation and fatal gscan)source.zipcontains a byte-identicalpnpm-workspace.yamland excludespnpm-lock.yamldtrace-provider: falsegit diff --check