Skip to content

🌐 Ship vi translations#135

Open
honhatduy wants to merge 3 commits intoTryGhost:mainfrom
honhatduy:main
Open

🌐 Ship vi translations#135
honhatduy wants to merge 3 commits intoTryGhost:mainfrom
honhatduy:main

Conversation

@honhatduy
Copy link

Based on en.json

@coderabbitai
Copy link

coderabbitai bot commented Mar 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 404d4d2b-485d-4c20-8703-0981e32faf73

📥 Commits

Reviewing files that changed from the base of the PR and between 17b2a40 and 9dec416.

📒 Files selected for processing (1)
  • locales/vi.json
✅ Files skipped from review due to trivial changes (1)
  • locales/vi.json

Walkthrough

Adds a new Vietnamese localization file at locales/vi.json containing 112 translation key/value pairs. Entries cover pagination, issue/post navigation, archive/browse/search labels, member/subscription and tier messaging, authentication prompts, UI controls (menu/fullscreen/zoom), RSS and Ghost attribution, and share/signup/login text. Strings include interpolation placeholders (e.g., {page}, {totalPages}, {numberOfIssues}, {authors}, {tiers}, {ghostlink}, {sitetitle}) and plural/quantity variants for counts and reading time.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title references adding Vietnamese translations with an emoji, which relates to the changeset, but includes non-descriptive elements (emoji, vague 'Ship') that reduce clarity about the actual change. Consider using a more descriptive title like 'Add Vietnamese localization (vi.json)' to clearly communicate the main change without relying on emojis or ambiguous terminology.
Description check ❓ Inconclusive The description 'Based on en.json' is related to the changeset but is extremely minimal and provides no meaningful context about what Vietnamese translations were added or why. Expand the description to explain the scope of translations added, any specific terminology choices made, or the intended use of the Vietnamese localization.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@locales/vi.json`:
- Line 92: Replace the incorrect noun in the translation for the key "This post
is for subscribers only": change the Vietnamese value from "Trang này chỉ dành
cho thành viên" to use "bài viết" (e.g., "Bài viết này chỉ dành cho thành viên")
so the wording matches "post" rather than "page".
- Line 3: The translation for the key " and " currently lacks the trailing
space—update the value for the token " and " in locales/vi.json to include both
surrounding spaces (i.e., change " và" to " và ") so concatenations preserve
spacing; ensure the exact token key " and " is updated and keep surrounding
whitespace intact in the JSON value.
- Line 31: The locale key uses a curly apostrophe "Don’t miss out on the latest
issues. Sign up now to get access to the library of members-only issues." which
doesn't match the canonical key with a straight apostrophe "Don't ..."; update
the key in the vi.json entry to use the straight apostrophe exactly ("Don't miss
out on the latest issues. Sign up now to get access to the library of
members-only issues.") so translation lookups succeed, and scan other locale
files for similar curly vs straight apostrophe mismatches to normalize them as
well.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1842c3b0-d1f7-482b-8c52-10c03ccc4839

📥 Commits

Reviewing files that changed from the base of the PR and between 214ab8a and 31812a8.

📒 Files selected for processing (1)
  • locales/vi.json

- Page/post
- Missiong space after "and"
Since this theme uses 'Topic', using 'Topic/Chủ đề' would be more accurate in Vietnamese.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant