Skip to content

chore(plugins): remove licensing contract#2

Merged
yordis merged 1 commit into
masterfrom
yordis/chore-remove-plugin-licensing
Jun 27, 2026
Merged

chore(plugins): remove licensing contract#2
yordis merged 1 commit into
masterfrom
yordis/chore-remove-plugin-licensing

Conversation

@yordis

@yordis yordis commented Jun 27, 2026

Copy link
Copy Markdown
Member
  • Keep the shared plugin contract aligned with a FOSS-only runtime so host integrations do not need to carry license placeholders.
  • Avoid making component authors provide licensing metadata for features that should be controlled through normal configuration and service registration.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Jun 27, 2026

Copy link
Copy Markdown

PR Summary

Cursor Bugbot is generating a summary for commit db2533f. Configure here.

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9aa82960-843d-455b-8eb9-f9c5f0832860

📥 Commits

Reviewing files that changed from the base of the PR and between 49c35af and db2533f.

📒 Files selected for processing (14)
  • src/EventStore.Plugins/Authentication/AuthenticationProviderBase.cs
  • src/EventStore.Plugins/Authorization/AuthorizationProviderBase.cs
  • src/EventStore.Plugins/EventStore.Plugins.csproj
  • src/EventStore.Plugins/IPlugableComponent.cs
  • src/EventStore.Plugins/LicenseException.cs
  • src/EventStore.Plugins/Licensing/ILicenseService.cs
  • src/EventStore.Plugins/Licensing/License.cs
  • src/EventStore.Plugins/Licensing/LicenseConstants.cs
  • src/EventStore.Plugins/Licensing/LicenseMonitor.cs
  • src/EventStore.Plugins/Plugin.cs
  • src/EventStore.Plugins/SubsystemsPlugin.cs
  • test/EventStore.Plugins.Tests/Licensing/LicenseMonitorTests.cs
  • test/EventStore.Plugins.Tests/Licensing/LicenseTests.cs
  • test/EventStore.Plugins.Tests/PluginBaseTests.cs
💤 Files with no reviewable changes (13)
  • src/EventStore.Plugins/Authentication/AuthenticationProviderBase.cs
  • test/EventStore.Plugins.Tests/Licensing/LicenseMonitorTests.cs
  • src/EventStore.Plugins/LicenseException.cs
  • src/EventStore.Plugins/Authorization/AuthorizationProviderBase.cs
  • src/EventStore.Plugins/EventStore.Plugins.csproj
  • src/EventStore.Plugins/Licensing/LicenseConstants.cs
  • src/EventStore.Plugins/Licensing/ILicenseService.cs
  • src/EventStore.Plugins/IPlugableComponent.cs
  • src/EventStore.Plugins/Licensing/License.cs
  • src/EventStore.Plugins/Licensing/LicenseMonitor.cs
  • test/EventStore.Plugins.Tests/Licensing/LicenseTests.cs
  • src/EventStore.Plugins/SubsystemsPlugin.cs
  • src/EventStore.Plugins/Plugin.cs

Walkthrough

All licensing infrastructure is removed from the plugin framework: ILicenseService, License, LicenseConstants, LicenseMonitor, LicenseException, and LicenseEntitlementException are deleted. IPlugableComponent, PluginOptions, Plugin, SubsystemsPlugin, AuthenticationProviderBase, and AuthorizationProviderBase drop all license-related constructor parameters and properties. Associated NuGet dependencies and tests are also removed.

Changes

Licensing infrastructure removal

Layer / File(s) Summary
Public contracts and PluginOptions updated
src/EventStore.Plugins/IPlugableComponent.cs, src/EventStore.Plugins/Plugin.cs, src/EventStore.Plugins/EventStore.Plugins.csproj, src/EventStore.Plugins/Licensing/*
IPlugableComponent drops LicensePublicKey; PluginOptions drops LicensePublicKey/RequiredEntitlements; Plugin constructors remove license params and the ConfigureApplication license monitoring block; ILicenseService, License, LicenseConstants, LicenseMonitor, LicenseException files deleted; JWT and Reactive NuGet refs removed.
Subtype constructors updated
src/EventStore.Plugins/SubsystemsPlugin.cs, src/EventStore.Plugins/Authentication/AuthenticationProviderBase.cs, src/EventStore.Plugins/Authorization/AuthorizationProviderBase.cs
SubsystemsPlugin, AuthenticationProviderBase, and AuthorizationProviderBase protected constructors remove licensePublicKey/requiredEntitlements parameters, keeping only diagnostics wiring.
Tests updated
test/EventStore.Plugins.Tests/Licensing/*, test/EventStore.Plugins.Tests/PluginBaseTests.cs
LicenseMonitorTests and LicenseTests deleted; PluginBaseTests removes licensing facts, drops license/crypto usings, and removes RequiredEntitlements from NightCityPlugin options.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 Hop hop, the licenses are gone,
No public keys to carry on!
The plugin runs with lighter feet,
No JWT to make complete.
Just diagnostics, clean and neat! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing the plugin licensing contract.
Description check ✅ Passed The description matches the PR goals by describing removal of licensing placeholders and metadata requirements.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/chore-remove-plugin-licensing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yordis yordis merged commit 1ab4835 into master Jun 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant