Complete type checking for OLMo support (builds on #816) #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally from TransformerLensOrg#718.
Fix to OLMo 2 normalization
Author
|
@jlarson4 do you know when this might be merged? |
Collaborator
Hi @taziksh! Sorry for taking so long to get back to you. The plan at present is to see if we can get the OLMo models incorporated into the 3.x beta. Bumping the minimum python version and updating jaxtyping are coming as part of 3.x, so we wanted to make sure this PR, which also includes those changes, is integrated in the same place. I am updating the base branch now and will let you know when it is incorporated into 3.x Thanks! |
# Conflicts: # debugging/hf-tl-logit-comparator.ipynb # demos/ARENA_Content.ipynb # demos/Colab_Compatibility.ipynb # demos/Main_Demo.ipynb # demos/Othello_GPT.ipynb # poetry.lock # pyproject.toml # transformer_lens/HookedEncoder.py # transformer_lens/HookedTransformer.py # transformer_lens/components/abstract_attention.py # transformer_lens/config/HookedTransformerConfig.py # transformer_lens/loading_from_pretrained.py # transformer_lens/utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on #816 and resolves all remaining type checking issues, allowing the OLMo implementation to pass mypy validation.
Changes:
create_alibi_multipliers(head_idx → n_heads)Type of change
Checklist: