Add plus button to instantiation cells#1041
Closed
tibisabau wants to merge 1 commit intoToposInstitute:mainfrom
Closed
Add plus button to instantiation cells#1041tibisabau wants to merge 1 commit intoToposInstitute:mainfrom
tibisabau wants to merge 1 commit intoToposInstitute:mainfrom
Conversation
4 tasks
Member
|
Closing, see #1040 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change improves the discoverability of adding new assignment lines in instantiation cells by introducing a visible "+" button. Previously, users could only add new assignments by pressing "Return" from an existing assignment line, which was not intuitive. The implementation adds an IconButton with a Plus icon below the specializations list that, when clicked, adds a new assignment at the end and automatically focuses it.
The solution follows the existing UI patterns in the codebase by:
Plusicon fromlucide-solid/icons/plusIconButtoncomponent fromcatcolab-ui-componentsCloses #891.
Checklist if Applicable
pnpm --filter ./packages/frontend run testpnpm --filter ./packages/frontend run lint