feat: store execution profile in metadata - #2631
feat: store execution profile in metadata#2631diogodanielsoaresferreira wants to merge 7 commits into
Conversation
| @Schema(nullable = true, description = "The name of the execution profile the run was submitted with.") | ||
| @JsonAlias({ "executionprofile" }) | ||
| @JsonInclude(JsonInclude.Include.NON_EMPTY) | ||
| private String executionProfile; |
There was a problem hiding this comment.
Maybe make this an enum with the known profiles?
There was a problem hiding this comment.
I would not set this on metadata but do the same as we do for configuration profile. Allow to set it via optional query parameter and then store it as system tag on the metadata. That way we keep it consistent with config profile and don't change the api contract.
There was a problem hiding this comment.
moreover, I also think we should support activating multiple profiles at the same time, think of debug profile that changes logging and troubleshooting profile that enables JFR and stores distance matrix
There was a problem hiding this comment.
Supporting multiple execution profiles at the same time makes sense, I updated it to use it. In this case, should we just drop the default execution profile, which basically it's empty?
| @Schema(nullable = true, description = "The name of the execution profile the run was submitted with.") | ||
| @JsonAlias({ "executionprofile" }) | ||
| @JsonInclude(JsonInclude.Include.NON_EMPTY) | ||
| private String executionProfile; |
There was a problem hiding this comment.
I would not set this on metadata but do the same as we do for configuration profile. Allow to set it via optional query parameter and then store it as system tag on the metadata. That way we keep it consistent with config profile and don't change the api contract.
| @Schema(nullable = true, description = "The name of the execution profile the run was submitted with.") | ||
| @JsonAlias({ "executionprofile" }) | ||
| @JsonInclude(JsonInclude.Include.NON_EMPTY) | ||
| private String executionProfile; |
There was a problem hiding this comment.
moreover, I also think we should support activating multiple profiles at the same time, think of debug profile that changes logging and troubleshooting profile that enables JFR and stores distance matrix
| WAYPOINTS("waypoints"), | ||
| PATCH_REQUEST("patch-request"); | ||
| PATCH_REQUEST("patch-request"), | ||
| EXECUTION_PROFILE_ARTIFACTS("execution-profile-artifacts"); |
There was a problem hiding this comment.
maybe rename this to EXECUTION_ARTIFACTS only, no need to mention profile, especially if we allow to activate more profiles at the same time
There was a problem hiding this comment.
Makes sense, updated
…eira/timefold-solver into execution_profiles
3 participants
Related with https://github.com/TimefoldAI/timefold-platform/pull/5469