fix: mark ModelConvertor parameters and returns as non-null (#2507)#2519
Open
vikas-prasad-cx wants to merge 1 commit into
Open
fix: mark ModelConvertor parameters and returns as non-null (#2507)#2519vikas-prasad-cx wants to merge 1 commit into
vikas-prasad-cx wants to merge 1 commit into
Conversation
…AI#2507) Clarify the API nullability contract with @NullMarked and enforce it in AbstractTrivialModelConvertor so callers cannot pass null arguments. Co-authored-by: Cursor <cursoragent@cursor.com>
vikas-prasad-cx
requested a deployment
to
external
July 18, 2026 16:34 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
vikas-prasad-cx
requested a deployment
to
external
July 18, 2026 16:34 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModelConvertorwith@NullMarkedand document that method parameters/returns are never null (use emptyOptionalfor no prior output).AbstractTrivialModelConvertorwith the same contract via runtimeObjects.requireNonNullchecks, removing the previous null-tolerantmodelOutputpath.Fixes #2507
Test plan
./mvnw test -pl service/definition -Dtest=ModelConvertorNullabilityTest./mvnw test -pl service/quarkus/deployment -Dtest=AbstractTrivialModelConvertorTest./mvnw test -pl service/definition,service/quarkus/deployment(40 tests passed)Made with Cursor