chore: remove eventing completion await by cristianonicolai · Pull Request #2503 · TimefoldAI/timefold-solver

cristianonicolai · 2026-07-15T11:39:33Z

No description provided.

Copilot

Pull request overview

This PR updates the worker post-processing flow to propagate the solveRequested flag into post-processors, and changes solver worker event emission to be non-blocking (no longer awaiting event-send completion).

Changes:

Extend ModelPostProcessor.processComputed(...) to accept a solveRequested boolean and pass it through from SolverWorker.
Update existing processComputed(...) implementations to match the new signature.
Replace blocking event-send awaiting with asynchronous completion logging when emitting events.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
service/worker/src/main/java/ai/timefold/solver/service/worker/impl/SolverWorker.java	Passes `solveRequested` into post-processing and makes event emission non-blocking with async error logging.
service/worker/src/main/java/ai/timefold/solver/service/worker/impl/log/LogsPostProcessor.java	Updates `processComputed` signature to accept `solveRequested`.
service/maps/service-client/src/main/java/ai/timefold/solver/service/maps/service/client/impl/processors/SaveWaypointsPostProcessor.java	Updates `processComputed` signature to accept `solveRequested`.
service/definition/src/main/java/ai/timefold/solver/service/definition/api/ModelPostProcessor.java	Changes `processComputed` API to include `solveRequested`.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

    private void sendEvent(Emitter emitter, AbstractEvent event) {
        try {
-            emitter.send(event).toCompletableFuture().get(EMITTER_TIMEOUT, TimeUnit.SECONDS);
-        } catch (ExecutionException | InterruptedException | TimeoutException e) {
-            if (e instanceof InterruptedException) {
-                Thread.currentThread().interrupt();
-            }
-            LOGGER.error("Error sending event: {}, message: {}", event, e.getMessage(), e);
+            CompletionStage<Void> stage = emitter.send(event);
+            stage.whenComplete((v, ex) -> {
+                if (ex == null) {


Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

+            CompletionStage<Void> stage = emitter.send(event);
+            stage.whenComplete((v, ex) -> {
+                if (ex == null) {
+                    return;
+                }


Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

+            stage.whenComplete((v, ex) -> {
+                if (ex == null) {
+                    return;
+                }
+                var cause = ex.getCause() != null ? ex.getCause() : ex;
+                LOGGER.error("Error sending event: {}, message: {}", event, cause.getMessage(), cause);
+            });


sonarqubecloud · 2026-07-20T01:31:38Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot AI review requested due to automatic review settings July 15, 2026 11:39

cristianonicolai requested review from rsynek and triceo as code owners July 15, 2026 11:39

cristianonicolai temporarily deployed to internal July 15, 2026 11:39 — with GitHub Actions Inactive

Copilot started reviewing on behalf of cristianonicolai July 15, 2026 11:40 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Comment thread ...e/definition/src/main/java/ai/timefold/solver/service/definition/api/ModelPostProcessor.java Outdated

Comment thread service/worker/src/main/java/ai/timefold/solver/service/worker/impl/SolverWorker.java Outdated

Copilot AI review requested due to automatic review settings July 15, 2026 11:50

cristianonicolai force-pushed the chore/messaging branch from 80e7f6b to ccf6990 Compare July 15, 2026 11:50

cristianonicolai temporarily deployed to internal July 15, 2026 11:51 — with GitHub Actions Inactive

Copilot started reviewing on behalf of cristianonicolai July 15, 2026 11:51 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 15, 2026 13:51

cristianonicolai force-pushed the chore/messaging branch from ccf6990 to 9272bf0 Compare July 15, 2026 13:51

cristianonicolai temporarily deployed to internal July 15, 2026 13:52 — with GitHub Actions Inactive

Copilot started reviewing on behalf of cristianonicolai July 15, 2026 13:52 View session

cristianonicolai force-pushed the chore/messaging branch from 9272bf0 to 17ce61a Compare July 15, 2026 13:53

cristianonicolai temporarily deployed to internal July 15, 2026 13:53 — with GitHub Actions Inactive

cristianonicolai changed the title ~~chore: Add solveRequested to postprocessor and remove eventing comple…~~ chore: remove eventing completion await Jul 15, 2026

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Comment thread service/worker/src/main/java/ai/timefold/solver/service/worker/impl/log/LogsPostProcessor.java

Comment thread .../timefold/solver/service/maps/service/client/impl/processors/SaveWaypointsPostProcessor.java

Copilot AI review requested due to automatic review settings July 15, 2026 13:55

Copilot started reviewing on behalf of cristianonicolai July 15, 2026 13:56 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Comment thread service/worker/src/main/java/ai/timefold/solver/service/worker/impl/log/LogsPostProcessor.java Outdated

Comment thread .../timefold/solver/service/maps/service/client/impl/processors/SaveWaypointsPostProcessor.java Outdated

Copilot AI review requested due to automatic review settings July 15, 2026 13:58

cristianonicolai force-pushed the chore/messaging branch from 17ce61a to 0ea70cb Compare July 15, 2026 13:58

cristianonicolai temporarily deployed to internal July 15, 2026 13:58 — with GitHub Actions Inactive

Copilot started reviewing on behalf of cristianonicolai July 15, 2026 13:58 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Comment thread service/worker/src/main/java/ai/timefold/solver/service/worker/impl/SolverWorker.java

Comment on lines +246 to +250

CompletionStage<Void> stage = emitter.send(event);

stage.whenComplete((v, ex) -> {

if (ex == null) {

return;

}

cristianonicolai temporarily deployed to internal July 16, 2026 04:25 — with GitHub Actions Inactive

Copilot AI review requested due to automatic review settings July 17, 2026 04:43

cristianonicolai force-pushed the chore/messaging branch from 0ea70cb to 6f3b591 Compare July 17, 2026 04:43

cristianonicolai temporarily deployed to internal July 17, 2026 04:43 — with GitHub Actions Inactive

Copilot started reviewing on behalf of cristianonicolai July 17, 2026 04:43 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

chore: remove eventing completion await

d838b4b

Copilot AI review requested due to automatic review settings July 20, 2026 01:09

cristianonicolai force-pushed the chore/messaging branch from 6f3b591 to d838b4b Compare July 20, 2026 01:09

cristianonicolai temporarily deployed to internal July 20, 2026 01:09 — with GitHub Actions Inactive

cristianonicolai deployed to internal July 20, 2026 01:09 — with GitHub Actions Active

Copilot started reviewing on behalf of cristianonicolai July 20, 2026 01:09 View session

Copilot AI reviewed Jul 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: remove eventing completion await#2503

chore: remove eventing completion await#2503
cristianonicolai wants to merge 1 commit into
TimefoldAI:mainfrom
cristianonicolai:chore/messaging

cristianonicolai commented Jul 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

sonarqubecloud Bot commented Jul 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

cristianonicolai commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

sonarqubecloud Bot commented Jul 20, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cristianonicolai commented Jul 15, 2026 •

edited

Loading