fix: quote fail-on description in action.yml to fix YAML parse error#83
Merged
Conversation
The unquoted description "...non-zero exit: error, warning, or info" contains a colon, which YAML parses as a nested mapping key instead of plain scalar text, breaking the composite action. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Catches the class of bug fixed in this PR (a YAML parse error in action.yml) before merge, instead of only surfacing it once a broken action.yml is tagged and consumed via the floating v1 release tag. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Dolphin Check previously used Tim-Pohlmann/Dolphin@v1, which only reflects the last release, so a broken action.yml on a branch was invisible to CI until it was tagged. Using ./ exercises the PR's own action.yml on every run. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a YAML parsing breakage in the repository’s composite GitHub Action by quoting an input description that contains a colon, and adds CI coverage to catch similar YAML/schema issues earlier.
Changes:
- Quote the
fail-oninput description inaction.ymlto prevent YAML from interpreting the colon as a mapping delimiter. - Update CI to run the action from the local checkout and add a job that validates
action.ymland workflow YAML files withaction-validator.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| action.yml | Quotes the fail-on description to avoid YAML parse errors caused by an unquoted colon. |
| .github/workflows/ci.yml | Runs the local action in CI and adds YAML validation via action-validator to prevent regressions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot review flagged that downloading the raw action-validator binary via curl with no checksum verification is a supply-chain risk. Switch to the maintainer's own published GitHub Action, pinned to a commit SHA, and pin the binary version via its `version` input instead of hardcoding a release URL. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fail-oninput toaction.ymlwhose description contains an unquoted colon (...non-zero exit: error, warning, or info), which YAML parses as a nested mapping key rather than plain text — breaking the composite action for anyone consuming it.Test plan
python3 -c "import yaml; yaml.safe_load(open('action.yml'))"succeeds locally🤖 Generated with Claude Code