Conversation
Handle channel-pinned bot notifications by querying the tickets DB directly instead of the cached getTicket path. This avoids a race where thread message events can be cached as "not a ticket" before SetChannelId commits. If a pinned-message event from the bot is in a ticket channel, the message is deleted inside a Sentry span; errors are reported to Sentry. The previous getTicket-based check was reorganized and duplicate logic removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handle channel-pinned bot notifications by querying the tickets DB directly instead of the cached getTicket path. This avoids a race where thread message events can be cached as "not a ticket" before SetChannelId commits. If a pinned-message event from the bot is in a ticket channel. The previous getTicket-based check was reorganized and duplicate logic removed.
Type of Change
Testing
Open a ticket in thread mode
Does the welcome message get deleted? if yes then it works xD
Checklist