Skip to content

feat(RM-40): Option to not send panels to a channel#22

Closed
DanPlayz0 wants to merge 5 commits intoTicketsBot-cloud:masterfrom
DanPlayz0:feat/rm-40
Closed

feat(RM-40): Option to not send panels to a channel#22
DanPlayz0 wants to merge 5 commits intoTicketsBot-cloud:masterfrom
DanPlayz0:feat/rm-40

Conversation

@DanPlayz0
Copy link
Copy Markdown
Contributor

@DanPlayz0 DanPlayz0 commented May 18, 2025

🚨 This pull request requires that TicketsBot-cloud/database#2 is merged.

This pull request introduces changes to handle cases where ChannelId and MessageId can be nil, improving robustness and error handling across the panel management backend and frontend. The most significant updates include making these fields nullable, adjusting logic to handle nil values gracefully, and updating the frontend to reflect these changes.

Backend Changes:

  • Made ChannelId and MessageId fields nullable in the panelBody and panelMessageData structs, and updated methods like IntoPanelMessageData and panelIntoMessageData to handle nil values safely. [1] [2]
  • Updated panel creation, deletion, and update logic to account for nil ChannelId or MessageId, ensuring no operations are attempted on invalid or missing data. [1] [2] [3]
  • Enhanced validation logic to skip validation for nil ChannelId and ensure proper handling of nullable fields.

Frontend Changes:

  • Updated ChannelDropdown in the panel creation form to allow a null value, with a "None" label to indicate no channel is selected.
  • Modified the panel management view to display "None" for panels without a channel and disable the "Resend" button if channel_id is null.

Notes

This PR was originally created in May, and was later updated; original changes can be found by comparing commits 482902c9163f3cc2dfb6ce587e55561ce9a7ea27 & 20a65e6288a20667e5581e49a62d43df64d0298e

@DanPlayz0 DanPlayz0 changed the title feat(rm-40): feat(RM-40): Option to not send panels to a channel May 18, 2025
@DanPlayz0 DanPlayz0 requested a review from a team as a code owner November 15, 2025 00:45
@DanPlayz0 DanPlayz0 marked this pull request as draft November 26, 2025 08:13
@DanPlayz0 DanPlayz0 closed this Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant