feat(RM-40): Option to not send panels to a channel#22
Closed
DanPlayz0 wants to merge 5 commits intoTicketsBot-cloud:masterfrom
Closed
feat(RM-40): Option to not send panels to a channel#22DanPlayz0 wants to merge 5 commits intoTicketsBot-cloud:masterfrom
DanPlayz0 wants to merge 5 commits intoTicketsBot-cloud:masterfrom
Conversation
20a65e6 to
06261ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to handle cases where
ChannelIdandMessageIdcan benil, improving robustness and error handling across the panel management backend and frontend. The most significant updates include making these fields nullable, adjusting logic to handlenilvalues gracefully, and updating the frontend to reflect these changes.Backend Changes:
ChannelIdandMessageIdfields nullable in thepanelBodyandpanelMessageDatastructs, and updated methods likeIntoPanelMessageDataandpanelIntoMessageDatato handlenilvalues safely. [1] [2]nilChannelIdorMessageId, ensuring no operations are attempted on invalid or missing data. [1] [2] [3]nilChannelIdand ensure proper handling of nullable fields.Frontend Changes:
ChannelDropdownin the panel creation form to allow anullvalue, with a "None" label to indicate no channel is selected.channel_idisnull.Notes
This PR was originally created in May, and was later updated; original changes can be found by comparing commits 482902c9163f3cc2dfb6ce587e55561ce9a7ea27 & 20a65e6288a20667e5581e49a62d43df64d0298e