Repository navigation
fix(docker): restore self-hosted UI and validate packaged assets (#290) - #292
Open
ThisIs-Developer wants to merge 10 commits into
Open
ThisIs-Developer wants to merge 10 commits into
ThisIs-Developer wants to merge 10 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying markdownviewer with
|
| Latest commit: |
1968567
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ce627e2e.markdownviewer.pages.dev |
| Branch Preview URL: | https://fix-290-docker-http-assets-s.markdownviewer.pages.dev |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What fixes #290
The reporter's Nginx log contains HTTP 400 responses to TLS ClientHello traffic (
\\x16\\x03). The Docker image was sendingContent-Security-Policy: upgrade-insecure-requestson its HTTP-only port 80, causing browsers accessing a LAN host to request styles/scripts over HTTPS. Changing the Compose mapping from8080:80to8719:80is valid and was not the root cause.Code and packaging changes
upgrade-insecure-requestsonly from the Docker/Nginx HTTP CSP. Keep Cloudflare Pages' HTTPS policy intact; TLS for self-hosted public deployments belongs at the reverse proxy.browser-drop-source.js,native-markdown-source.js,preview-worker.js, andsample.md. Permit the sample via.dockerignore..mjsfiles withapplication/javascript(the stock Nginx image returnedapplication/octet-stream, breaking ES modules withnosniff).Verification — actual Docker image built in GitHub Actions
Latest successful run: Build and Push Docker Image #1202 on PR head
19685671d03decbeaff0ca33f03b7d60921c212b..mjshttp://<server-ip>:8719on Raspberry Pi / another LAN machinepush: false)Reproduce and inspect
We deliberately have not merged or published
:latest. Docker tests cover the container and Playwright smoke; the complete non-Docker E2E suite and physical Raspberry Pi browser retest have not been executed here.Fixes #290.