Skip to content

Fix RTL Markdown list rendering and spacing (Issue #259) - #260

Merged
ThisIs-Developer merged 4 commits into
ThisIs-Developer:mainfrom
rajat12826:fix-rtl-list-rendering
Sep 26, 2026
Merged

ThisIs-Developer merged 4 commits into
ThisIs-Developer:mainfrom
rajat12826:fix-rtl-list-rendering

Conversation

@rajat12826

Copy link
Copy Markdown
Contributor

Closes #259

Description:
This PR fixes two rendering discrepancies between the Markdown Viewer and native GitHub Markdown:

  1. RTL List Bullets: Added proper padding handling for lists when rendered in RTL ([dir="rtl"]), ensuring that bullet points align securely within the container instead of rendering out of bounds.
  2. List-to-Paragraph Spacing: Removed custom margin overrides on .markdown-body ul and .markdown-body ol inside styles.css. This allows the application to naturally inherit GitHub's native 16px margin styling for standard spacing between lists and subsequent block elements (like paragraphs).

Changes Made:

  • Removed margin: 0.4em 0; and nested list margins from ul and ol elements in styles.css.
  • Added [dir="rtl"] overrides for lists in styles.css to apply padding-right: 2em; and padding-left: 0;.

Testing Performed:

  • Verified that LTR lists maintain standard 16px spacing before paragraphs.
  • Verified that RTL mode properly aligns bullet points without clipping on the right side.

@vercel

vercel Bot commented Sep 25, 2026

Copy link
Copy Markdown

@rajat12826 is attempting to deploy a commit to the BS Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
markdown-viwer Ready Ready Preview Sep 26, 2026 5:16pm UTC

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

RTL behavior must cover the split preview, and regression tests are needed.

Review effort: Lite
Findings: 1 High severity · 1 Low severity

Open (2)
Resolved since last review (2)

@rajat12826

Copy link
Copy Markdown
Contributor Author

The desktop resource is fully synced — both styles.css and desktop-app/resources/styles.css were updated in the same commit a6058e9. npm run build passes locally with "Static build smoke check passed.

@ThisIs-Developer

Copy link
Copy Markdown
Owner

The desktop resource is fully synced — both styles.css and desktop-app/resources/styles.css were updated in the same commit a6058e9. npm run build passes locally with "Static build smoke check passed.

It looks like the latest review may be carrying forward findings from an older issue of the PR, even though those points were already addressed. I also cross-checked the current changes with additional review agents, and they did not find any remaining blocking issue.

Screenshot 2026-09-26 230234

Based on the current state of the PR, I’m approving and merging it.

Thank you, @rajat12826 for the contribution and especially for responding so quickly to the review feedback and updating the PR along the way.

Thanks again for helping improve Markdown Viewer!

@ThisIs-Developer
ThisIs-Developer merged commit d9c3d64 into ThisIs-Developer:main Sep 26, 2026
4 checks passed

This branch was successfully deployed

1 active deployment
Preview — a6058e90 Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RTL Markdown list rendering differs from GitHub

3 participants