Fix RTL Markdown list rendering and spacing (Issue #259) - #260
Conversation
|
@rajat12826 is attempting to deploy a commit to the BS Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
The desktop resource is fully synced — both styles.css and desktop-app/resources/styles.css were updated in the same commit a6058e9. npm run build passes locally with "Static build smoke check passed. |
It looks like the latest review may be carrying forward findings from an older issue of the PR, even though those points were already addressed. I also cross-checked the current changes with additional review agents, and they did not find any remaining blocking issue.
Based on the current state of the PR, I’m approving and merging it. Thank you, @rajat12826 for the contribution and especially for responding so quickly to the review feedback and updating the PR along the way. Thanks again for helping improve Markdown Viewer! |




Closes #259
Description:
This PR fixes two rendering discrepancies between the Markdown Viewer and native GitHub Markdown:
[dir="rtl"]), ensuring that bullet points align securely within the container instead of rendering out of bounds.marginoverrides on.markdown-body uland.markdown-body olinsidestyles.css. This allows the application to naturally inherit GitHub's native16pxmargin styling for standard spacing between lists and subsequent block elements (like paragraphs).Changes Made:
margin: 0.4em 0;and nested list margins fromulandolelements instyles.css.[dir="rtl"]overrides for lists instyles.cssto applypadding-right: 2em;andpadding-left: 0;.Testing Performed:
16pxspacing before paragraphs.