Names for the thinkwatch-data tool rule, and two code rules missing from notifications - #281
Merged
Merged
Conversation
…ng from notifications Core's new built-in tool rule `thinkwatch-data` (ThinkWatch-Core#287) gets its Chinese name and why in core.zh.json, and the matcher text for its `builtin` check in both languages. Until core ships it these entries are unused; the security page falls back to core's English name until then. Notifications for tool-call hits name built-in rules from their own table, which never got `secret-to-unknown-host` or `upload-file-to-host`, so those two showed their raw ids. All three are added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thinkwatch-data(Tool-call inspection guards ThinkWatch's own data directory; the docs say what protects config.yaml ThinkWatch-Core#287, "Read or change ThinkWatch's own data") gets its Chinese name and why insrc/i18n/core.zh.json, and the matcher text for itsbuiltincheck (thinkwatch-data) in both languages insrc/security/labels.i18n.tsx. Unused until a core release includes the rule; until then nothing changes, and after the bump the security page shows the Chinese name instead of falling back to core's English one.src-tauri/src/notices/rules.rs, which never gotsecret-to-unknown-hostorupload-file-to-host, so those two showed their raw ids. Both are added, together withthinkwatch-data.Checked locally:
pnpm typecheck,pnpm test(752 passed),cargo fmt --checkon the changed Rust file.🤖 Generated with Claude Code