Skip to content

Room poller: always nudge on owner messages + fix silent tmux delivery #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThinkOffApp merged 1 commit into from
Jul 6, 2026
Merged

Room poller: always nudge on owner messages + fix silent tmux delivery #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/team-relay/room-poller.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,10 @@ export async function startRoomPoller({ rooms, apiKey, handle, interval, config,
const nudgeCommandText = config?.poller?.nudge_command || '';
const pollInterval = parsePositiveInt(interval || config?.poller?.interval_sec, 30);
const selfHandle = normalizeHandle(handle || config?.poller?.handle || '@unknown');
// The human owner's handle. Messages from the owner ALWAYS nudge, even in
// emergency-only mode — a message from the user is itself the priority signal;
// emergency-only is meant to mute agent/fleet chatter, not the user's own words.
const ownerHandle = normalizeHandle(config?.poller?.owner_handle || 'petrus');

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use the configured owner instead of hard-coded Petrus

When intent.userId belongs to anyone other than petrus and existing configs don't set the new, undocumented poller.owner_handle, owner messages still won't set hasOwnerMessage, so shouldSuppressNudge(config) continues to suppress the user's own messages in emergency-only mode. Conversely, messages from @petrus bypass suppression even when the configured intent user is someone else. This default should be derived from the configured owner/user identity, such as config.intent.userId, rather than a fixed handle.

Useful? React with 👍 / 👎.

const dmCfg = config?.dm_poller || {};
const dmEnabled = dmCfg.enabled === true;
const dmHandle = normalizeHandle(dmCfg.handle || selfHandle);
Expand Down Expand Up @@ -224,6 +228,7 @@ export async function startRoomPoller({ rooms, apiKey, handle, interval, config,
roomPollInFlight = true;
try {
let newCount = 0;
let hasOwnerMessage = false;
const newMessages = [];
for (const room of rooms) {
const msgs = await fetchRoomMessages(room, apiKey);
Expand All @@ -236,6 +241,7 @@ export async function startRoomPoller({ rooms, apiKey, handle, interval, config,
const normalizedSender = normalizeHandle(sender);
// Skip own messages
if (normalizedSender === selfHandle) continue;
if (normalizedSender === ownerHandle) hasOwnerMessage = true;

const body = (m.body || '').slice(0, 500);
const ts = m.created_at || new Date().toISOString();
Expand Down Expand Up @@ -271,11 +277,12 @@ export async function startRoomPoller({ rooms, apiKey, handle, interval, config,
if (newCount > 0) {
// Primary: write to notification file (always works)
appendNotifications(notifyFile, newMessages);
if (await shouldSuppressNudge(config)) {
if (!hasOwnerMessage && await shouldSuppressNudge(config)) {
console.log(` ${newCount} new message(s) → notified (nudge suppressed: user emergency-only)`);
} else {
const nudged = triggerNudge({ nudgeMode, nudgeCommandText, nudgeText, session });
console.log(` ${newCount} new message(s) → notified${nudged ? ' + nudge' : ''}`);
const why = hasOwnerMessage ? ' (owner message — nudge forced)' : '';
console.log(` ${newCount} new message(s) → notified${nudged ? ' + nudge' : ''}${why}`);
}
}
} finally {
Expand All @@ -288,6 +295,7 @@ export async function startRoomPoller({ rooms, apiKey, handle, interval, config,
dmPollInFlight = true;
try {
let newCount = 0;
let hasOwnerMessage = false;
const newMessages = [];
const directMessages = await fetchDirectMessages(dmApiKey, dmLimit);
for (const message of directMessages) {
Expand All @@ -297,6 +305,7 @@ export async function startRoomPoller({ rooms, apiKey, handle, interval, config,
dmSeen.add(mid);

const sender = normalizeHandle(message.from || message.sender) || '?';
if (sender === ownerHandle) hasOwnerMessage = true;
const recipient = normalizeHandle(message.to) || dmHandle;
const body = (message.body || '').slice(0, 500);
const ts = message.created_at || new Date().toISOString();
Expand Down Expand Up @@ -328,11 +337,12 @@ export async function startRoomPoller({ rooms, apiKey, handle, interval, config,

if (newCount > 0) {
appendNotifications(dmNotifyFile, newMessages);
if (await shouldSuppressNudge(config)) {
if (!hasOwnerMessage && await shouldSuppressNudge(config)) {
console.log(` ${newCount} new direct message(s) → notified (nudge suppressed: user emergency-only)`);
} else {
const nudged = triggerNudge({ nudgeMode, nudgeCommandText, nudgeText, session });
console.log(` ${newCount} new direct message(s) → notified${nudged ? ' + nudge' : ''}`);
const why = hasOwnerMessage ? ' (owner message — nudge forced)' : '';
console.log(` ${newCount} new direct message(s) → notified${nudged ? ' + nudge' : ''}${why}`);
}
}
} finally {
Expand Down
Loading