Skip to content

fix(dx8wrapper): Prevent undefined behavior when converting Vector4 colors #3655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CryoTheRenegade wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

fix(dx8wrapper): Prevent undefined behavior when converting Vector4 colors #3655

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a533ce1
refactor(ww3d2): Pass the Vector4 color to Convert_Color without a Ve…
CryoTheRenegade Oct 26, 2026
273f99f
refactor(ww3d2): Copy the Vector4 color into a Vector3 instead of the…
CryoTheRenegade Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Core/Libraries/Source/WWVegas/WW3D2/dx8wrapper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1131,14 +1131,14 @@ WWINLINE void DX8Wrapper::Clamp_Color(Vector4& color)

WWINLINE unsigned int DX8Wrapper::Convert_Color(const Vector4& color)
{
return Convert_Color(reinterpret_cast<const Vector3&>(color),color[3]);
return Convert_Color(Vector3(color.X,color.Y,color.Z),color.W);
}

WWINLINE unsigned int DX8Wrapper::Convert_Color_Clamp(const Vector4& color)
{
Vector4 clamped_color=color;
DX8Wrapper::Clamp_Color(clamped_color);
return Convert_Color(reinterpret_cast<const Vector3&>(clamped_color),clamped_color[3]);
return Convert_Color(clamped_color);
}

#endif
Expand Down
Loading