Unified height map code from Zero Hour to Generals causes mismatch for Generals replays #3610

Activity

1. Caball009

   added

   ThisProjectThe issue was introduced by this project, or this task is specific to this projectThe issue was introduced by this project, or this task is specific to this project

   on Oct 26, 2026
2. Caball009

   added the

   Bug

   issue type on Oct 26, 2026
3. Caball009 commented on Oct 26, 2026

   

   Caball009

   on Oct 26, 2026

   Author

   More actions

   @xezon Can you take a look? #1991 is too large for me to take apart.
4. coderabbitai commented on Oct 26, 2026

   

   coderabbitaiBot

   on Oct 26, 2026 – with coderabbitai

   Last edited by coderabbitai

   More actions

   🔗 Related PRs

   #3644 - bugfix(baseheightmap): Restore Generals retail compatibility from floor math changes in BaseHeightMapRenderObjClass::getHeightMapHeight() [open]
   #3634 - bugfix(worldheightmap): Restore Generals retail compatibility of the cliff state of maps up to version 7 [open]
   #3645 - fix: Replace fast_float_trunc, fast_float_floor, fast_float_ceil with standard or deterministic equivalents for all configurations except retail compatible Zero Hour [open]

   ---

   🧪 Issue enrichment is currently in open beta.

   You can configure auto-planning by selecting labels in the issue_enrichment configuration.

   To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

   issue_enrichment:
     auto_enrich:
       enabled: false

   💬 Have feedback or questions? Drop into our discord!
5. Caball009

   changed the title [-]Copying height map code from Zero Hour to Generals causes mismatch for Generals replay[/-] [+]Unified height map code from Zero Hour to Generals causes mismatch for Generals replay[/+] on Oct 26, 2026
6. xezon

   self-assigned this

   on Oct 28, 2026
7. Caball009 commented on Nov 4, 2026

   

   Caball009

   on Nov 4, 2026

   Last edited by Caball009

   Author

   More actions

   I noticed an interesting issue with a Zero Hour map used with Generals. Here's a Generals replay and Zero Hour custom map: replay_custom_map.zip from https://www.gamereplays.org/community/index.php?s=0&showtopic=990750&st=20&p=10248122&#entry10248122.

   The retail Zero Hour executable (from Steam) can play this replay without mismatch, but the entire terrain is black. IIRC after #1991 the black terrain is fixed, but the replay mismatches. There's a workaround, which is to open this custom map with the Steam Generals World Builder and save it. After that it's playable without mismatch (or black terrain). Current builds of the GEN WB can't do that.
8. Caball009

   changed the title [-]Unified height map code from Zero Hour to Generals causes mismatch for Generals replay[/-] [+]Unified height map code from Zero Hour to Generals causes mismatch for Generals replays[/+] on Nov 4, 2026
9. xezon

   closed this as completedin #3644on Nov 9, 2026
10. Caball009

    reopened this on Nov 9, 2026