Fix negative volunteer counts caused by observer bug#826
Merged
Conversation
The EventsUsersObserver::deleted() method was incorrectly decrementing the volunteer count for ALL deleted events_users records, not just confirmed volunteers. Bug: Line 89 passed 4 parameters to removed() which only accepts 3. The 4th parameter ($eu->status == 1) was silently ignored, so $count was always true, causing incorrect decrements when invitations (non-confirmed users) were deleted. Fix: Pass $eu->status == 1 as the 3rd parameter instead of true. Also includes: - Migration to fix existing incorrect volunteer counts - Three new tests to prevent regression - Updated CLAUDE.md with Task/Docker documentation
|
…counts Migration was too aggressive - volunteer counts can be manually adjusted, so mismatches aren't necessarily wrong. Only negative counts are always wrong. Replace with targeted artisan command (dev:fixvolunteercount). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Brings in Laravel 10 + group tags. Conflict resolutions: - app/Observers/EventsUsersObserver.php: kept HEAD's 3-arg removed() call (which is the actual fix for this PR — the 4-arg call was the bug) but added develop's null guard, which is required because L10's type hints now make removed(User $user) strict and $user can be null when iduser is unset. - app/Console/Commands/FixVolunteerCount.php: kept HEAD's more detailed docblock, dropped the obsolete @return mixed tag. - CLAUDE.md: combined HEAD's detailed task:docker command reference with develop's "Run Vite for HMR" note.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventsUsersObserver::deleted()method passed 4 parameters toremoved()which only accepts 3, causing the status check to be silently ignoredevents_usersrecord was decrementing the count, even for invited (non-confirmed) users who were never countedRoot Cause
Line 89 in
EventsUsersObserver.php:Changes
EventsUsersObserver.php- correctly pass$eu->status == 1as the$countparametertestDeletingInvitedVolunteerDoesNotDecrementCounttestDeletingConfirmedVolunteerDecrementsCounttestMultipleInvitationDeletionsCauseNegativeCountTest plan