Improve Scripts#713
Conversation
61f482a to
3ecf5ba
Compare
rzuckerm
left a comment
There was a problem hiding this comment.
This is way too big of a change. There is no way I will accept this PR, sorry!
|
I would have to agree. While I like the bits that use the image titler as a subprocess, this is a colossal rewrite of a system that has more or less been working as-is. If you want to make these kinds of sweeping changes, I would prefer they were broken up into reasonably reviewable pull requests. |
|
Like even just the third commit is a massive rewrite. Perhaps it was possible to whip that up quickly. But on the off chance there was some AI assistance, that somewhat goes against the spirit of the repo. It also just creates a ton of work for our humble team of maintainers (i.e., mainly @rzuckerm). Because he puts so much work in, I feel obligated to support him here. |
Thanks for helping us build up our knowledge base!
What kind of pull request have you brought us today?
Please make sure to familiarize yourself with the Contributing Guide.
Pull Request Type
Please fill out this form in the following way:
Please specify the type of pull request (please only check one of these):
The title of this pull request must be one of the following:
Add {PROJECT} in {LANGUAGE} Article. For example,Add Hello World in Erlang Article.Add {LANGUAGE} Language Article. For example,Add Erlang Language Article`.Add {PROJECT} in Every Language Article. For example,Add Zeckendorf in Every Language Article.If you are modify an existing article, please change "Add" to "Modify" in the title.
This pull request must have a corresponding issue number. If you have
not already done so, please create a new issue.
Please put in the relevant issue number in the
I fixed #your-issue-number-hereitem. For example, if your PR isfor an issue called
Add Hello World in Erlang Article, and that issue number is156, changeyour-issue-number-hereto
156. Do not put any space between#and the issue number. This is important because when the PR is merged,the corresponding issue will be closed.
Notes
I attempted to make the script more performant where it was reasonable and easier to maintain. I also fixed some typos that I've noticed, as well as migrate many of the functions to more modern Python equivalents. I believe this is more robust overall, but I'll let you be the judge. I also attempted to have a repo cache that all other functions reuse, because the functions iterate through the repo many times, but I'm tired. Good thing I didn't do that on the old monolith.