Skip to content

Improve Scripts#713

Open
pascalecu wants to merge 26 commits into
TheRenegadeCoder:mainfrom
pascalecu:improve-scripts
Open

Improve Scripts#713
pascalecu wants to merge 26 commits into
TheRenegadeCoder:mainfrom
pascalecu:improve-scripts

Conversation

@pascalecu
Copy link
Copy Markdown
Member

Thanks for helping us build up our knowledge base!
What kind of pull request have you brought us today?
Please make sure to familiarize yourself with the Contributing Guide.

Pull Request Type

Please fill out this form in the following way:

[x] Right :)
[x ] Wrong: :(
[ x] Wrong: :(
[ x ] Wrong :(

Please specify the type of pull request (please only check one of these):

  • Sample Program Documentation
  • Language Documentation
  • Project Documentation
  • Other (explain in the Notes section)

The title of this pull request must be one of the following:

  • Sample Program Documentation: Add {PROJECT} in {LANGUAGE} Article. For example,
    Add Hello World in Erlang Article.
  • Language Documentation: Add {LANGUAGE} Language Article. For example, Add Erlang Language Article`.
  • Project Documentation: Add {PROJECT} in Every Language Article. For example,
    Add Zeckendorf in Every Language Article.

If you are modify an existing article, please change "Add" to "Modify" in the title.

This pull request must have a corresponding issue number. If you have
not already done so, please create a new issue.

Please put in the relevant issue number in the I fixed #your-issue-number-here item. For example, if your PR is
for an issue called Add Hello World in Erlang Article, and that issue number is 156, change your-issue-number-here
to 156. Do not put any space between # and the issue number. This is important because when the PR is merged,
the corresponding issue will be closed.

Notes

I attempted to make the script more performant where it was reasonable and easier to maintain. I also fixed some typos that I've noticed, as well as migrate many of the functions to more modern Python equivalents. I believe this is more robust overall, but I'll let you be the judge. I also attempted to have a repo cache that all other functions reuse, because the functions iterate through the repo many times, but I'm tired. Good thing I didn't do that on the old monolith.

@pascalecu pascalecu requested a review from a team May 18, 2026 03:10
@pascalecu pascalecu self-assigned this May 18, 2026
Copy link
Copy Markdown
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way too big of a change. There is no way I will accept this PR, sorry!

@jrg94
Copy link
Copy Markdown
Member

jrg94 commented May 19, 2026

I would have to agree. While I like the bits that use the image titler as a subprocess, this is a colossal rewrite of a system that has more or less been working as-is. If you want to make these kinds of sweeping changes, I would prefer they were broken up into reasonably reviewable pull requests.

@jrg94
Copy link
Copy Markdown
Member

jrg94 commented May 19, 2026

Like even just the third commit is a massive rewrite. Perhaps it was possible to whip that up quickly. But on the off chance there was some AI assistance, that somewhat goes against the spirit of the repo. It also just creates a ton of work for our humble team of maintainers (i.e., mainly @rzuckerm). Because he puts so much work in, I feel obligated to support him here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Scripts

3 participants