Repository navigation
Discussions follow-up: a slash-leading message is text, a user-message answer is end_turn - #6
Merged
Merged
Conversation
…a command A session/prompt carrying _meta.documentor skips slash-command detection, so a message such as "/cc Anna" is stored as text instead of being run as a command or dropped as an unknown one. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
v1 prompt answers with the newest message when the session has nothing answerable, which can be a user message. promptResponse answers end_turn without usage for it instead of reading tokens off a user info. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
- prompt.ts: the comment above revert.cleanup says a stored-only message commits a pending revert too; a documentor: test pins it. - FORK.md: the loop's nothing-answerable return is the newest assistant message; service.ts skips slash detection for _meta.documentor and answers a user-message answer with end_turn; the SDK is generated from the server's OpenAPI. - tests: the two no-idle-wait tests restore events.push in finally. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 72 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5 from its whole-branch review. documentor/FORK.md rows are updated.
acp/service.ts: asession/promptthat carries_meta.documentoris never read as a slash command — a discussion message such as/cc Annais stored as text instead of being run or dropped. Requests without the meta keep today's command handling.acp/service.ts:promptResponseanswersend_turnwithout usage when v1 returns a user message (a session with nothing answerable), instead of readingtokensoff a user info.session/prompt.ts/ FORK.md: a prompt of any kind, a stored-only message included, commits a pending revert; wording of the loop's nothing-answerable return.events.pushrestored infinally.Verified locally: the touched test files in full,
bun turbo typecheck.🤖 Generated with Claude Code