Repository navigation
test(core): assert migrateAll only on the schemas the test owns - #3
Merged
Merged
Conversation
The test database is shared by every package's tests, and turbo runs them
in parallel: opencode's tests create and drop throwaway schemas while this
test's migrateAll scans every schema holding opencode's tables. One dropped
mid-scan lands in `failed` ("SELECT id FROM migration"), which failed the
documentor-pg push run after the tool-delta-reads merge. Reproduced locally
by looping this test beside test/session/: 8 failures in 275 runs before,
0 in 247 after.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 72 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
documentor-pgpush run after PR #1 (tool-delta-reads) merged failed in@opencode-ai/core:migration lifecycle > migrateAll brings every schema … up to dategot afailedentry for a schema it never created (SELECT id FROM migrationont_bc9c…). The test database is shared by every package's tests and turbo runs them in parallel, so opencode's throwaway schemas are created and dropped whilemigrateAllscans every schema holding opencode's tables.What
The test asserts
failedonly for its own three schemas.migrateAllitself is unchanged.Verification
Looping this test beside
packages/opencodetest/session/on one Postgres: 8 failures in 275 runs with the old assertion, 0 in 247 with the new one.test/pg/migration.test.tspasses (17).🤖 Generated with Claude Code