Repository navigation
ACP changes for DocuMentor's queued messages: messageId, empty-prompt resume, _meta.opencode - #2
Merged
Merged
Conversation
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 72 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… and tool update Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…y for tracked sessions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TheFabFab
force-pushed
the
queued-messages
branch
from
October 9, 2026 08:40
6b5fbd9 to
caadf43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes DocuMentor's queued messages rely on. Each keeps upstream behaviour for clients that do not use it (documentor/FORK.md has a row for each):
acp/service.ts: asession/promptmessageIdstarting withmsgbecomes the durable user message id. UUID ids (other ACP clients) are not forwarded; the unchanged test "normal text prompt sends model variant mode and converted parts" guards that.session/prompt.ts: a prompt with no parts on a session that has a user message stores nothing and runs the loop. Nothing to answer means no model call; a fresh session keeps upstream behaviour.acp/event.ts:agent_message_chunk,agent_thought_chunk,tool_callandtool_call_updatecarry_meta.opencode = { messageId, parentId }, live and replayed.Verified locally: the
documentor:tests per file,binary-smoke.shon a--singlebuild, and DocuMentor's layer-1 suite (13 tests against realopencode acp) on that build, where 6 of them fail on the currently releasedv1.18.34-documentor-pg.1.Layer-1 results
Built with
OPENCODE_VERSION=1.18.34 bun run script/build.ts --singleat6b5fbd923; sha25647e137a73e2ec0168e1e064a614e529ba4bb00e69b108a494324e57fb5f05fab(baseline release6157dbc0…889a).v1.18.34-documentor-pg.1_meta.opencode)Notes
queued-messages, notdocumentor/queued-messages. This fork already has adocumentorbranch, so git cannot create adocumentor/…branch here (a ref directory/file conflict).binary-smoke.shpassed against the embedded server'spostgresdatabase, as in CI. The local test database (agentstate_test) refuses CONNECT to the scope role, and the released binary fails there the same way.What remains unproven
🤖 Generated with Claude Code