add --bundle-dir option to web subcommand#650
add --bundle-dir option to web subcommand#650TimJentzsch merged 10 commits intoTheBevyFlock:mainfrom
--bundle-dir option to web subcommand#650Conversation
addf29a to
ce6b483
Compare
DaAlbrecht
left a comment
There was a problem hiding this comment.
I'm open to this but do you think this is still needed even if the Bundle path is part of the API?
DaAlbrecht
left a comment
There was a problem hiding this comment.
My bad, wanted to just leave some comments, didn't mean to approve already
|
@musjj are you still willing to work on this PR? If not, I can label it so someone else can adopt the work! No pressure either way :) |
|
Sorry for the incredibly long delay. But yeah, I'm still very much interested in this! I think this feature is still helpful for reducing the guesswork that comes with copying bundle directories, even if I've addressed the comments above. |
DaAlbrecht
left a comment
There was a problem hiding this comment.
Thanks a lot and sorry for the delay! Could you also add a section to the Changelog, and then this is ready to go imo.
|
Ok, updated the changelog! |
cookie1170
left a comment
There was a problem hiding this comment.
You should also mention it in the book in the 'Creating web bundles' section of 'Web Apps', otherwise looks good
TimJentzsch
left a comment
There was a problem hiding this comment.
Just one minor comment, looks good to me otherwise :)
Add an option for copying a packed web bundle directory to a user-specified directory. This lets you skip any error-prone parsing/guessing when locating the bundle directory, which is usually useful for CI-related tasks.
The behavior is modeled after the unstable
--artifact-diroption fromcargo:--artifact-dir(nee--out-dir) Tracking Issue rust-lang/cargo#6790Fix: #649