Skip to content

fix(machine_learning): call features.any() in linear_discriminant_analysis #15606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hardikkaurani wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

fix(machine_learning): call features.any() in linear_discriminant_analysis #15606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion machine_learning/dimensionality_reduction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def linear_discriminant_analysis(
assert classes > dimensions

# Check if features have been already loaded
if features.any:
if features.any():
_, eigenvectors = eigh(
covariance_between_classes(features, labels, classes),
covariance_within_classes(features, labels, classes),
Expand Down Expand Up @@ -363,6 +363,11 @@ def test_linear_discriminant_analysis() -> None:
)
assert error_info.type is AssertionError

with pytest.raises(AssertionError):
linear_discriminant_analysis(
np.array([]), np.array([]), classes=2, dimensions=1
)


def test_principal_component_analysis() -> None:
features = np.array([[1, 2, 3], [4, 5, 6], [7, 8, 9]])
Expand Down
Loading