Skip to content

fix: parenthesize multiple exception types in greatest_common_divisor.py#14940

Open
vishwagna wants to merge 2 commits into
TheAlgorithms:masterfrom
vishwagna:fix-gcd-syntax-error
Open

fix: parenthesize multiple exception types in greatest_common_divisor.py#14940
vishwagna wants to merge 2 commits into
TheAlgorithms:masterfrom
vishwagna:fix-gcd-syntax-error

Conversation

@vishwagna

Copy link
Copy Markdown

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Fixes #14929

Restores parenthesized syntax for multiple exception types in
maths/greatest_common_divisor.py. A ruff pre-commit autoupdate (#14325)
rewrote the previously-correct except (IndexError, UnboundLocalError, ValueError):
into invalid Python 3 syntax, causing a SyntaxError at import time and
breaking downstream imports in maths/least_common_multiple.py and
maths/primelib.py.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SyntaxError in maths/greatest_common_divisor.py — invalid Python 3 except clause

1 participant