feat: add PyFock phase-one backend - #123
Merged
Merged
Conversation
- Codex (GPT-6 Astra): engine adapter, dispatch, UI gating, tests, and docs - Jonathan Schultz: overall vision, planning, review, and orchestration Co-authored-by: Jonathan Schultz <nccu-schultz-lab@users.noreply.github.com> Co-authored-by: Codex (GPT-6 Astra) <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements M-PYFOCK Phase 1 (PYF.2–PYF.6), establishing PyFock as QuantUI's first alternate quantum-chemistry engine for a guarded native-Windows-capable DFT subset.
Mol/Basis/DFTadapter and normalizedEngineResult[pyfock]extra plus a dedicated Windows/Python 3.11 real-calculation CI gateValidated subset
PyFock Phase 1 intentionally supports:
B3LYP/PBE0 remain gated because PyFock 0.1.7 does not yet implement the required exact exchange. Geometry optimization, solvent, GPU, checkpoints, SLURM, post-HF, and orbital analysis remain future phases.
Validation
<1e-5 HaThe dedicated native-Windows PyFock job added here is expected to provide the first Windows hardware/software gate on this PR.
Attribution