Pull upstream (API refactoring) and update tests#314
Pull upstream (API refactoring) and update tests#314openroad-ci wants to merge 16 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
This reverts commit 2ed1c2c. Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Adapt all cpp/tcl test files to match upstream OpenSTA API changes: - string* output params changed to string return values (Verilog, Network) - Report methods renamed (reportLineString->reportLine, printf->std::format) - Delay type refactored from float typedef to class (Graph) - Liberty model APIs updated (value semantics, shared_ptr, PocvMode) - EXPECT_STREQ -> EXPECT_EQ for std::string returns (Sdc, Search) - streamPrint -> sta::print with std::format specifiers (Spice) - Avoid unset_clock_groups -all path (upstream iterator invalidation bug) Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
|
|
|
@dsengupta0628 please give a first review |
dsengupta0628
left a comment
There was a problem hiding this comment.
This looks fine- everything is contained within */test/ module
|
I picked up commit aac881a from this branch: secure-bump-opensta-0321 into my branch sta_update_upstream_lvf_stuff, and verified it compiles fine too. Updated my PR with this |
|
#318 already combines these changes. And I picked specific commit from Jaehyun that enables STA compilation |
Summary
rename Report virtuals to warnMsg etc)Upstream changes by module
string*output params →stringreturn values (remove&from call sites)reportLineString→reportLine/report, printf format →std::format({})Delaytype refactored from float to class, addedStaState/DelayOpsScalartest fixtureshared_ptr<TableModel>,PocvMode)EXPECT_STREQ→EXPECT_EQforstd::string,asString→to_string, avoidunset_clock_groups -all(upstream iterator invalidation bug)EXPECT_STREQ→EXPECT_EQforGroupPath::name()streamPrint→sta::printwithstd::formatspecifiersTest plan
make -j)