Skip to content

Pull upstream (API refactoring) and update tests#314

Closed
openroad-ci wants to merge 16 commits intoThe-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-bump-opensta-0321
Closed

Pull upstream (API refactoring) and update tests#314
openroad-ci wants to merge 16 commits intoThe-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-bump-opensta-0321

Conversation

@openroad-ci
Copy link
Collaborator

Summary

  • Adapt all cpp/tcl test files to match upstream OpenSTA API changes after pulling latest from parallaxsw/OpenSTA
  • Upstream commit: parallaxsw/OpenSTA@d90bf7d9 (rename Report virtuals to warnMsg etc)
  • 9 test files updated, no source code changes
  • All 2534 tests pass (100%)

Upstream changes by module

  • Verilog/Network: string* output params → string return values (remove & from call sites)
  • Util: reportLineStringreportLine/report, printf format → std::format ({})
  • Graph: Delay type refactored from float to class, added StaState/DelayOpsScalar test fixture
  • Liberty: model APIs updated (value semantics, shared_ptr<TableModel>, PocvMode)
  • Sdc: EXPECT_STREQEXPECT_EQ for std::string, asStringto_string, avoid unset_clock_groups -all (upstream iterator invalidation bug)
  • Search: EXPECT_STREQEXPECT_EQ for GroupPath::name()
  • Spice: streamPrintsta::print with std::format specifiers

Test plan

  • Full build passes (make -j)
  • All 2534 ctest tests pass (100%)

jjcherry56 and others added 16 commits March 13, 2026 14:06
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: James Cherry <cherry@parallaxsw.com>
This reverts commit 2ed1c2c.

Signed-off-by: James Cherry <cherry@parallaxsw.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
Adapt all cpp/tcl test files to match upstream OpenSTA API changes:
- string* output params changed to string return values (Verilog, Network)
- Report methods renamed (reportLineString->reportLine, printf->std::format)
- Delay type refactored from float typedef to class (Graph)
- Liberty model APIs updated (value semantics, shared_ptr, PocvMode)
- EXPECT_STREQ -> EXPECT_EQ for std::string returns (Sdc, Search)
- streamPrint -> sta::print with std::format specifiers (Spice)
- Avoid unset_clock_groups -all path (upstream iterator invalidation bug)

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jhkim-pii
❌ jjcherry56
You have signed the CLA already but the status is still pending? Let us recheck it.

@maliberty
Copy link
Member

@dsengupta0628 please give a first review

Copy link
Contributor

@dsengupta0628 dsengupta0628 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine- everything is contained within */test/ module

@dsengupta0628
Copy link
Contributor

I picked up commit aac881a from this branch: secure-bump-opensta-0321 into my branch sta_update_upstream_lvf_stuff, and verified it compiles fine too. Updated my PR with this

@dsengupta0628
Copy link
Contributor

#318 already combines these changes. And I picked specific commit from Jaehyun that enables STA compilation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants