Skip to content

clkTreeDelay to check arc without assuming it exists #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 2 commits into from
Mar 20, 2026
+3 −5
Merged

clkTreeDelay to check arc without assuming it exists #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e45eff
clkTreeDelay to check arc without assuming it exists
dsengupta0628 Mar 19, 2026
2e0b35c
regolden regression- expected original developer's path- updated to r…
dsengupta0628 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion liberty/Liberty.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2761,7 +2761,7 @@ LibertyPort::clkTreeDelay(float in_slew,
|| (arc_set->role() == TimingRole::clockTreePathMax()
&& min_max == MinMax::max())) {
const TimingArc *arc = arc_set->arcTo(to_rf);
if (arc->fromEdge()->asRiseFall() == from_rf) {
if (arc && arc->fromEdge()->asRiseFall() == from_rf) {
const GateTableModel *gate_model = dynamic_cast<GateTableModel*>(arc->model());
if (gate_model)
return gate_model->delayModel()->findValue(in_slew, 0.0, 0.0);
Expand Down
4 changes: 1 addition & 3 deletions spice/test/spice_write.ok
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,4 @@ Path Type: max
9.92 slack (MET)


Differences found at line 2.
.include "/workspace/sta/OpenSTA/spice/test/results/spice_out/mock_model.sp"
.include "/workspace/sta2/OpenSTA/spice/test/results/spice_out/mock_model.sp"
No differences found.
2 changes: 1 addition & 1 deletion spice/test/spice_write.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ write_path_spice \
-model_file $model_file \
-power VDD \
-ground VSS
diff_files $test_name.spok [file join $spice_dir path_1.sp]
diff_files $test_name.spok [file join $spice_dir path_1.sp] "mock_model.sp"
Loading