Conversation
only create instances toggle if debug mode is active, draw charts when gui is active Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the graphics initialization and update logic within the GPL module. Key changes include extracting chart initialization into a dedicated initCharts() method, making the routing_chart_ conditional on routability_driven_mode, and renaming initHeatmap() to initDebugHeatmap(). Debug-specific graphics setup, such as adding display controls and instance selection, is now explicitly gated by a debug_on_ flag and the presence of a debug_inst parameter. Additionally, the updateIterGraphics function was refined to ensure iteration data is always added if graphics are available, while more resource-intensive debug updates are strictly controlled by the npVars_.debug flag.
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
| static gui::Chart* main_chart_; | ||
| static gui::Chart* density_chart_; | ||
| static gui::Chart* stepLength_chart_; | ||
| static gui::Chart* routing_chart_; |
There was a problem hiding this comment.
We were generating the main_chart_ twice and populating it only once. I suspect it was because we can build the nesterov object more than once at replace.cpp. This guarantees we don't generate anything twice.
rearrange return logic Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
3 participants
Only show GUI toggle for GPL debug instances drawings if GPL debug mode is active.
Some other reorganization for debug mode and GPL charts.