build: add VS Code DevContainer support for seamless onboarding#9818
build: add VS Code DevContainer support for seamless onboarding#9818Divinesoumyadip wants to merge 4 commits intoThe-OpenROAD-Project:masterfrom
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Code Review
This pull request introduces DevContainer support, which is a valuable addition for streamlining the developer onboarding process. My review focuses on refining the configuration for robustness and maintainability. I've suggested simplifying the VS Code extensions list by removing redundant entries and correcting the postCreateCommand to prevent potential container lifecycle issues. These changes will help ensure a smooth experience for developers using the new DevContainer environment.
…boarding Signed-off-by: Divinesoumyadip <soumyacode7@gmail.com>
d9616c5 to
6679a6e
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Hi @vvbandeira Please chcek it out .Thanks in advance . |
|
@Divinesoumyadip I have mixed feelings about this PR. If the goal is simply to provide an additional way to use/develop OR, I'm okay with merging it. We previously tried devcontainers for ORFS, but we abandoned that approach. I also don't think this is the best onboarding path. It assumes users will work in a devcontainer (most likely via VS Code). For users who don't already use VS Code or another IDE with devcontainer support, requiring them to install a new IDE works against ease of use. |
@vvbandeira Thanks for the detailed review! |
Then the PR is fine.
If VSCode let's their user know somehow that the repo has a |
@vvbandeira Thanks! I'll add a brief note about the DevContainer in |
Signed-off-by: Divinesoumyadip <soumyacode7@gmail.com>
|
@vvbandeira I've added a note about the DevContainer in |
|
clang-tidy review says "All clean, LGTM! 👍" |
docs/user/BuildWithDocker.md
Outdated
There was a problem hiding this comment.
Duplicated sections, this filename does not match the contents -- also we already have a section on Docker.
Rename the file, add a reference in the correct place.
Please review your own PR carefully to make sure you have committed and pushed the correct set.
There was a problem hiding this comment.
Duplicated sections, this filename does not match the contents -- also we already have a section on Docker. Rename the file, add a reference in the correct place. Please review your own PR carefully to make sure you have committed and pushed the correct set.
@vvbandeira Done now check.Thanks
Signed-off-by: Divinesoumyadip <soumyacode7@gmail.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Divinesoumyadip <soumyacode7@gmail.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Currently, developers using Docker must manually run container build commands, configure volume mounts, and manually attach their IDEs to the container environment. This creates friction and a steep learning curve for first-time contributors.
By adding native DevContainer support, users can now simply open the cloned repository in VS Code and click "Reopen in Container".
This configuration automatically:
devtarget in our existingDockerfile(leveraging the optimized base image).cpptools,cmake-tools, etc.).