dpl: check edge spacing DRC on opt_mirror - #11054
Open
gadfort wants to merge 2 commits into
Open
Conversation
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request integrates LEF58 cell edge spacing rule checks into the mirroring optimization process. It updates the OptimizeMirroring class to accept and utilize Network, Grid, and PlacementDRC engines to verify if mirroring a cell would violate edge spacing rules, rejecting candidates that do. A new test case mirror_edge_spacing is also added to verify this behavior. The feedback suggests adding safety checks for network_ and grid_ pointers in isEdgeSpacingLegal to prevent potential null pointer dereferences, as these pointers can be null when edge spacing checks are skipped.
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optimize_mirror was missing the check on edge spacing rules, this wires in the check.
Note this was generated by Claude, but verified on my failing PDK
Type of Change
Impact
Fix detail placement invalid cell placements
Verification
./etc/Build.sh).Related Issues
[Link issues here]