grt: enable post-DRT antenna repair when using CUGR by eder-matheus · Pull Request #11053 · The-OpenROAD-Project/OpenROAD

eder-matheus · 2026-08-03T12:51:37Z

Summary

When using CUGR, we just skipped post-DRT repair antennas. Now, we repair the antenna violations similar to how FastRoute does:

CUGR data structures are initialized with congestion information from wires. This is necessary to prevent new congestion hotspots when rerouting the modified nets.
repair_antennas detects the violations from the detail route results and fixes the violations using diode insertion.
CUGR reroutes the modified nets, ensuring that all the pins of a net will be covered.

New test repair_antennas_post_drt_cugr covers the flow end to end with real detailed routing: CUGR route → detailed_route → 4 violations on the wires → 4 diodes → second detailed_route → 0 violations on the final wires (~20 s, deterministic; the first post-DRT repair test for either engine).

Type of Change

New feature

Impact

CUGR sessions can repair antennas after detailed routing instead of skipping; antenna_diodes_count is reported and repaired nets hand fresh guides to the DRT ECO. Diode-net reroutes account for existing wire demand. FastRoute behavior is unchanged — existing goldens byte-identical, including repair_antennas_from_odb.

Verification

I have verified that the local build succeeds (./etc/Build.sh).
I have run the relevant tests and they pass.
My code follows the repository's formatting guidelines.
I have included tests to prevent regressions.
I have signed my commits (DCO).

Related Issues

None.

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

…ate/OpenROAD into grt_cugr_repair_antennas_jumper

eder-matheus · 2026-08-03T12:52:34Z

@codex review

gemini-code-assist

Code Review

This pull request implements rebuilding the engine state from detailed routes for CUGR during antenna repair, aligning its behavior with FastRoute. It introduces makeRouteFromWires to convert detailed wires into a gcell-granularity route, and updates the antenna repair and route update flows to handle CUGR state restoration and wire destruction. Additionally, a new integration test is added to verify post-detailed-route antenna repair with CUGR. Feedback was provided regarding a potential null pointer dereference in makeRouteFromWires when retrieving a via shape, which could lead to a segmentation fault.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a74885061

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

eder-matheus · 2026-08-04T12:44:53Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 112a4e8461

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…ate/OpenROAD into grt_cugr_repair_antennas_jumper Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

…ate/OpenROAD into grt_cugr_repair_antennas_jumper

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

…ate/OpenROAD into grt_cugr_repair_antennas_jumper

eder-matheus · 2026-08-05T19:51:46Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d740399103

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-05T20:01:28Z

-            fastroute_->getNetId(db_net, net_id, exists);
-            ndr_nets.emplace_back(db_net, net_id);
+    if (use_cugr_) {
+      initCUGR(min_layer, max_layer);


Reset CUGR state before reinitializing

When repair_antennas is invoked after an earlier global_route -use_cugr/detailed_route, this re-enters initCUGR() on the existing CUGR instance. CUGR::init() appends to gr_nets_, net_indices_, and db_net_map_ without clearing the previous contents, so after this new path the object contains duplicate GRNet entries; a subsequent full CUGR route scans gr_nets_, routes the same indices repeatedly, and can commit stale demand multiple times. Clear or recreate the CUGR state before this re-init.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-08-05T20:01:28Z

+        for (int level = via_min_layer;
+             level < std::min(via_max_layer, max_layer);
+             level++) {


Project above-range pins when clamping adopted vias

When a detailed route reaches a top-level pin on max_layer + 1, this loop now clamps the via stack to stop at max_layer, but GRNet still creates that pin's access point on the actual above-range pin layer and restoreNetRoute() requires one of those AP cells to be present in the restored tree. Fresh evidence beyond the earlier via-bound issue is that the new coverage validation rejects the clamped tree even though buildTreeFromRoute() no longer rejects the via segment, so the net falls into the failed-adoption path and its detailed-route demand is not modeled during antenna repair; project the coverage AP to the routing ceiling as well.

AGENTS.md reference: AGENTS.md:L20-L20

Useful? React with 👍 / 👎.

eder-matheus added 5 commits August 3, 2026 02:26

grt: add makeRouteFromWires to build routes from detailed wires

98df788

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

grt: support repair_antennas from detailed routes with CUGR

ccee1c2

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

grt: add repair_antennas_post_drt_cugr test

0c0dd2c

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

grt: simplify wire route conversion and post-DRT test log

82773cf

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

Merge branch 'master' of https://github.com/The-OpenROAD-Project-priv…

1a74885

…ate/OpenROAD into grt_cugr_repair_antennas_jumper

eder-matheus self-assigned this Aug 3, 2026

github-actions Bot added the size/M label Aug 3, 2026

gemini-code-assist Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread src/grt/src/GlobalRouter.cpp

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread src/grt/src/GlobalRouter.cpp Outdated

Comment thread src/grt/src/GlobalRouter.cpp Outdated

eder-matheus added 8 commits August 3, 2026 13:11

grt: shorten comments in CUGR antenna repair

9954b38

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

grt: derive adopted wire routes from centerline points

9eaed29

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

grt: clamp adopted vias to the max routing layer

21570f8

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

grt: report demand adoption counts under debug

dc821c7

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

grt: keep pin access layers in adopted wire routes

849ff54

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

grt: report per-net demand adoption under debug

c8f934f

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

grt: account for wrong-way wires in CUGR demand adoption

defbe6f

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

grt: simplify wrong-way demand support after review

c44f2d3

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

chatgpt-codex-connector Bot reviewed Aug 4, 2026

View reviewed changes

Comment thread src/grt/src/GlobalRouter.cpp

Merge branch 'master' of https://github.com/The-OpenROAD-Project-priv…

6a306b5

…ate/OpenROAD into grt_cugr_repair_antennas_jumper Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

openroad-ci force-pushed the grt_cugr_repair_antennas_jumper branch from 112a4e8 to 6a306b5 Compare August 4, 2026 13:03

eder-matheus added 7 commits August 4, 2026 13:15

grt: rename CUGR wrong-way tree provenance flag to adopted

b210262

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

grt: make below-min pin-access spans inert in adopted CUGR trees

a2901cc

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

grt: test below-min pin-access span adoption in CUGR post-DRT repair

0c198c9

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

Merge branch 'master' of https://github.com/The-OpenROAD-Project-priv…

bb6d580

…ate/OpenROAD into grt_cugr_repair_antennas_jumper

grt: fix tclfmt formatting in below-min cugr test

1689715

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

grt: remove unused variable in buildTreeFromRoute

0cbe4dc

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>

Merge branch 'master' of https://github.com/The-OpenROAD-Project-priv…

d740399

…ate/OpenROAD into grt_cugr_repair_antennas_jumper

chatgpt-codex-connector Bot reviewed Aug 5, 2026

View reviewed changes

Navigation Menu

Uh oh!

grt: enable post-DRT antenna repair when using CUGR - #11053

grt: enable post-DRT antenna repair when using CUGR#11053
eder-matheus wants to merge 21 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:grt_cugr_repair_antennas_jumper

eder-matheus commented Aug 3, 2026

Uh oh!

eder-matheus commented Aug 3, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

eder-matheus commented Aug 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

eder-matheus commented Aug 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Aug 5, 2026

Uh oh!

chatgpt-codex-connector Bot Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

eder-matheus commented Aug 3, 2026

Summary

Type of Change

Impact

Verification

Related Issues

Uh oh!

eder-matheus commented Aug 3, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

eder-matheus commented Aug 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

eder-matheus commented Aug 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 5, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Aug 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant