Cts fix level creation infint loop - #11019
Merged
precisionmoon merged 3 commits intoAug 5, 2026
Merged
Conversation
Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
Signed-off-by: arthurjolo <arthurjl@precisioninno.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a stop criterion in the H-Tree builder loop within HTreeBuilder.cpp. Specifically, it tracks the previous maximum half-perimeter wire length (HPWL) and terminates the loop early if the current HPWL does not improve. Additionally, a new integration test max_wl_two_sinks is added to verify this behavior and prevent regressions where the loop would otherwise run to maximum depth. There are no review comments, and I have no feedback to provide.
precisionmoon
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prevents an infinite loop during the CTS level creation. It is possible that 2 sinks always cluster together during level creation and the
maxHPWLnever drops belowmaxWl, creating an infinite loop.Type of Change
Impact
Add a check if the maxHPWL drops after creating a level. If it doesn't, it means that creating more levels will never meet the conditions
maxHPWL < maxWl, and it stops creating levels.Verification
./etc/Build.sh).Related Issues
[Link issues here]