Skip to content

Fix temporary sv-lang pointing to different repo.#10688

Open
hzeller wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
hzeller:feature-20260618-fix-svlang
Open

Fix temporary sv-lang pointing to different repo.#10688
hzeller wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
hzeller:feature-20260618-fix-svlang

Conversation

@hzeller

@hzeller hzeller commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

The relevant BCR PR is long merged.

Also: We should never point to other repositories for the BCR.

@hzeller hzeller requested a review from a team as a code owner June 18, 2026 15:01
@hzeller hzeller requested a review from precisionmoon June 18, 2026 15:01

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the temporary custom Bazel registry configurations from .bazelrc and updates the sv-lang dependency version to 10.0.1-20260316-f04e8156 in MODULE.bazel. There are no review comments to address, and no further feedback is provided.

@maliberty

Copy link
Copy Markdown
Member

conflicts to resolve

@hzeller hzeller force-pushed the feature-20260618-fix-svlang branch from f196828 to 7cd438d Compare June 18, 2026 20:28
The relevant BCR PR is long merged.

Also: We should _never_ point to other repositories for the BCR.

Signed-off-by: Henner Zeller <h.zeller@acm.org>
@hzeller hzeller force-pushed the feature-20260618-fix-svlang branch from 7cd438d to a5cabd5 Compare June 18, 2026 20:50
@hzeller

hzeller commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator Author

It would be good if the check module.bazel CI test would output a diff of what it expects.
I am using a slightly different bazel version (8.7), so I can't quite generate what the CI expects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants