dpl: remove universal cell height assumption#10684
Open
gudeh wants to merge 7 commits into
Open
Conversation
… for all instances, instead fetch instance height from db to define pixel grid height relative to instance Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
…pixels Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the NegotiationLegalizer to support hybrid-row designs with non-uniform row heights. It removes the uniform row_height_ member variable and instead utilizes dpl_grid APIs (such as gridSnapDownY, gridYToDbu, and gridHeight) to handle coordinate conversions and height calculations. Additionally, it adds logging to report cell height distributions. There are no review comments, and I have no further feedback to provide.
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the assumption that every instance shares a single universal
row_height_in the negotiation legalizer. Add cell-height distribution reporting.Replace every
row_height_usage with the DPL grid's own helpers, which already account for per-row heights:In the negotiation legalizer, log the distribution in grid row-counts (info message DPL-392/393). Easy to see at a glance whether a design is single- or multi-height.
Type of Change
Impact
Some private designs with hybrid rows or multi height rows would present issues because of this assumption.
On uniform-height designs this is no-op. The grid helpers reduce to the same arithmetic the old code did with
row_height_.Verification
./etc/Build.sh).Related Issues
This is one of multiple PRs splitting up PR #10226 to make Negotiation the default algorithm at DPL.