pdn: add check for instance halo to ensure it does not overlap rows#10657
pdn: add check for instance halo to ensure it does not overlap rows#10657gadfort wants to merge 2 commits into
Conversation
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
|
@mole99 FYI |
There was a problem hiding this comment.
Code Review
This pull request introduces a halo overlap check for macro instances in the PDN generator. It adds hasHalo(), suggestHalo(), and checkHalo() methods to InstanceGrid to detect when a macro's halo overlaps with standard cell rows and suggests a reduced halo size to resolve the conflict. Feedback on the changes highlights a potential underestimation in row bloat calculation due to integer division truncation when a followpin strap has an odd width, suggesting rounding up instead.
|
Fix the tcl lint. I think the bazel failure is unrelated |
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
|
@maliberty it looks like the tinyrocket needs to have its powergrid grid fixed, but when I do I get metrics failures. How do I update those? |
|
@maliberty also I should mention most of the runtime of this test is actually global routing attempting to disable NDRs. |
I assume you mean the one in OR and not the one in ORFS. |
Summary
Users keep running into issues where the PDN halo differs from the cut rows halo, causing issues/errors when PDN is inserting vias. This adds a check to ensure the powergrid instance halos do not overlap the follow pins on the standard cells.
Type of Change
Impact
If the powergrid setup is correct, no impact is expected, but if the grid has an overlap issue, this will break.
Verification
./etc/Build.sh).