fix: Use sRGB color space for IFC material colors#135
Merged
Conversation
Contributor
|
Thanks for this! We'll review it and, if everything is ok, merge asap :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IFC material colors are stored in sRGB color space, but were being passed directly to THREE.Color() which treats input values as linear RGB in Three.js r152+.
This caused colors to appear washed out - dark greys appeared lighter, and colors lost saturation because sRGB values were incorrectly interpreted as linear.
The fix uses THREE.Color().setRGB(r, g, b, THREE.SRGBColorSpace) to properly convert from sRGB to linear color space internally.
What is the purpose of this pull request?