Repository navigation
fix(core): type FragmentsManager.init options as FragmentsModelsOptions - #835
Merged
Merged
Conversation
Contributor
|
Merged, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #834
FragmentsManager.initpassesoptionsstraight tonew FragmentsModels(workerURL, options), but typed it as{ classicWorker?: boolean }, somaxWorkersandthreadGroupsneeded a cast. It now usesFRAGS.FragmentsModelsOptions, which @thatopen/fragments 3.4.7 (the version in the lockfile) exports withclassicWorker,maxWorkersandthreadGroups.Additional context
Checked with
tsc --noEmit -p tsconfig-build.jsoninpackages/core: it passes, and a scratch file callinginit(url, { maxWorkers: 4, threadGroups: { data: 1 } })compiles with the change and fails with TS2353 without it. I did not add a test since the change is type-only.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).